Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Changelog of 3.5 and 3.4 #19028

Merged
merged 2 commits into from
Dec 7, 2024
Merged

Conversation

deanurag
Copy link
Contributor

@deanurag deanurag commented Dec 6, 2024

Updated Versions in the changelog file .
Part of #19000

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

Hi @deanurag. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.76%. Comparing base (f128d89) to head (0d90af4).
Report is 6 commits behind head on main.

Additional details and impacted files

see 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19028      +/-   ##
==========================================
- Coverage   68.81%   68.76%   -0.06%     
==========================================
  Files         420      420              
  Lines       35623    35623              
==========================================
- Hits        24515    24496      -19     
- Misses       9688     9706      +18     
- Partials     1420     1421       +1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f128d89...0d90af4. Read the comment docs.

@ahrtr
Copy link
Member

ahrtr commented Dec 6, 2024

/ok-to-test

@@ -10,6 +10,7 @@ Previous change logs can be found at [CHANGELOG-3.4](https://github.com/etcd-io/

### Package `clientv3`
- Fix [runtime panic that occurs when KeepAlive is called with a Context implemented by an uncomparable type](https://github.com/etcd-io/etcd/pull/18937)
- Compile binaries using [go 1.22.10](https://github.com/etcd-io/etcd/pull/19004).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this item under ## Dependencies

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a section ## Dependencies below (line 20), please add this item there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

below line 20 , is the section of etcd grpc-proxy, do you want me to add the same thing there ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the section is not nested. The dependencies listed there are not from etcd grpc-proxy. Thanks!

@ahrtr
Copy link
Member

ahrtr commented Dec 6, 2024

@deanurag please try commands something like below,

git reset --soft HEAD~1
git checkout -- scripts/release.sh
git add .
git commit --signoff -m "Update changelog for both 3.4 and 3.5 to cover the go version bumping"

# manually sync your github repo with upstream: on your fork repo deanurag/etcd page, click "sync fork"
git checkout main
git pull

git checkout update/ChangeLog
git rebase main
git push origin update/ChangeLog -f

@ahrtr
Copy link
Member

ahrtr commented Dec 6, 2024

@@ -11,11 +11,13 @@ Previous change logs can be found at [CHANGELOG-3.4](https://github.com/etcd-io/
### Package `clientv3`
- Fix [runtime panic that occurs when KeepAlive is called with a Context implemented by an uncomparable type](https://github.com/etcd-io/etcd/pull/18937)


### etcd grpc-proxy
- Add [`tls min/max version to grpc proxy`](https://github.com/etcd-io/etcd/pull/18829) to support setting TLS min and max version.

## Dependencies
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please feel free to resolve this in a separate PR.

Suggested change
## Dependencies
### Dependencies

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in #19031

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me squash the commits for you this time.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, deanurag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit bbe48b3 into etcd-io:main Dec 7, 2024
35 checks passed
@ahrtr ahrtr mentioned this pull request Dec 7, 2024
ivanvc pushed a commit to ivanvc/etcd that referenced this pull request Dec 12, 2024
* Update changelog for both 3.4 and 3.5 to cover the go version bumping

Signed-off-by: Anurag De <[email protected]>

---------

Signed-off-by: Anurag De <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants