-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Changelog of 3.5 and 3.4 #19028
Conversation
Hi @deanurag. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 24 files with indirect coverage changes @@ Coverage Diff @@
## main #19028 +/- ##
==========================================
- Coverage 68.81% 68.76% -0.06%
==========================================
Files 420 420
Lines 35623 35623
==========================================
- Hits 24515 24496 -19
- Misses 9688 9706 +18
- Partials 1420 1421 +1 Continue to review full report in Codecov by Sentry.
|
/ok-to-test |
CHANGELOG/CHANGELOG-3.5.md
Outdated
@@ -10,6 +10,7 @@ Previous change logs can be found at [CHANGELOG-3.4](https://github.com/etcd-io/ | |||
|
|||
### Package `clientv3` | |||
- Fix [runtime panic that occurs when KeepAlive is called with a Context implemented by an uncomparable type](https://github.com/etcd-io/etcd/pull/18937) | |||
- Compile binaries using [go 1.22.10](https://github.com/etcd-io/etcd/pull/19004). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this item under ## Dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already a section ## Dependencies
below (line 20), please add this item there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
below line 20 , is the section of etcd grpc-proxy, do you want me to add the same thing there ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the section is not nested. The dependencies listed there are not from etcd grpc-proxy
. Thanks!
04a38fd
to
3ed0004
Compare
cf52c19
to
ed1ef40
Compare
@deanurag please try commands something like below,
|
Signed-off-by: Anurag De <[email protected]>
ed1ef40
to
ac7f4e3
Compare
Signed-off-by: Anurag De <[email protected]>
@@ -11,11 +11,13 @@ Previous change logs can be found at [CHANGELOG-3.4](https://github.com/etcd-io/ | |||
### Package `clientv3` | |||
- Fix [runtime panic that occurs when KeepAlive is called with a Context implemented by an uncomparable type](https://github.com/etcd-io/etcd/pull/18937) | |||
|
|||
|
|||
### etcd grpc-proxy | |||
- Add [`tls min/max version to grpc proxy`](https://github.com/etcd-io/etcd/pull/18829) to support setting TLS min and max version. | |||
|
|||
## Dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please feel free to resolve this in a separate PR.
## Dependencies | |
### Dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated in #19031
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me squash the commits for you this time.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, deanurag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Update changelog for both 3.4 and 3.5 to cover the go version bumping Signed-off-by: Anurag De <[email protected]> --------- Signed-off-by: Anurag De <[email protected]>
Updated Versions in the changelog file .
Part of #19000
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.