Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gofump error due to merge race #18979

Merged
merged 1 commit into from
Dec 1, 2024
Merged

Conversation

serathius
Copy link
Member

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Marek Siarkowicz <[email protected]>
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.75%. Comparing base (278a9a2) to head (093df6f).
Report is 2 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/server.go 81.89% <ø> (+0.14%) ⬆️

... and 15 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18979      +/-   ##
==========================================
+ Coverage   68.72%   68.75%   +0.03%     
==========================================
  Files         420      420              
  Lines       35598    35598              
==========================================
+ Hits        24463    24474      +11     
+ Misses       9706     9699       -7     
+ Partials     1429     1425       -4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 278a9a2...093df6f. Read the comment docs.

@serathius serathius merged commit 3d46df1 into etcd-io:main Dec 1, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants