Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] release: properly change working dir if tmp location already exists #18863

Merged
merged 1 commit into from
Nov 12, 2024
Merged

[3.5] release: properly change working dir if tmp location already exists #18863

merged 1 commit into from
Nov 12, 2024

Conversation

ghouscht
Copy link
Contributor

Backport of #18812 to 3.5 according to the release plan of 3.5.17 (#18846)

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@ivanvc @ghouscht
release: properly change working dir if tmp location already exists
76275d6 
Currently, the script won't change directories into the previously
cloned repository if the temporary location exists. This may be an issue
when testing first with a dry run and later with the actual release.

Signed-off-by: Ivan Valdes <[email protected]>
@k8s-ci-robot
Copy link

Hi @ghouscht. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ghouscht
Copy link
Contributor Author

/assign @ivanvc

@ghouscht ghouscht mentioned this pull request Nov 11, 2024
Closed
2 tasks
@ivanvc
Copy link
Member

ivanvc commented Nov 11, 2024

/retest

@ivanvc
Copy link
Member

ivanvc commented Nov 11, 2024

/ok-to-test

ivanvc
ivanvc approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @ghouscht.

@ivanvc
Copy link
Member

ivanvc commented Nov 11, 2024

/cc @jmhbnz

@k8s-ci-robot k8s-ci-robot requested a review from jmhbnz November 11, 2024 22:23
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ghouscht, ivanvc, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit 307f9dc into etcd-io:release-3.5 Nov 12, 2024
27 checks passed
@ghouscht ghouscht deleted the backport-18812-3.5 branch November 12, 2024 13:15
@github-actions github-actions bot mentioned this pull request Nov 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

@serathius serathius serathius approved these changes

@ivanvc ivanvc ivanvc approved these changes

@jmhbnz jmhbnz Awaiting requested review from jmhbnz

Assignees

@ivanvc ivanvc

Labels
approved ok-to-test size/S
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ghouscht @k8s-ci-robot @ivanvc @serathius @ahrtr