Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build subtargets based on ARCH #18083

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

ArkaSaha30
Copy link
Contributor

This PR will group similar targets as per architecture into subtargets to build. It also adds a build-all target to build all OS-ARCH combinations.

Conversation: kubernetes/test-infra#32672 (comment)
Fixes: kubernetes/test-infra#32672

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

Hi @ArkaSaha30. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ArkaSaha30 ArkaSaha30 changed the title Add build subtargets based on arch Add build subtargets based on ARCH May 28, 2024
@jmhbnz
Copy link
Member

jmhbnz commented May 28, 2024

/ok-to-test

scripts/build_subtargets.sh Outdated Show resolved Hide resolved
@ahrtr
Copy link
Member

ahrtr commented May 28, 2024

We have two options,

  • [preferred] add Makefile targets build-limux-amd64, build-linux-arm64, etc. and build-all. We don't need to add or change any script files.
build-linux-amd64:
    GOOS=linux GOARCH=amd64 GO_BUILD_FLAGS="${GO_BUILD_FLAGS} -v -mod=readonly" ./scripts/build.sh

......

build-all: build-limux-amd64 build-linux-arm64 ......

  • This PR

@ArkaSaha30
Copy link
Contributor Author

/retest pull-etcd-integration-1-cpu-amd64

@k8s-ci-robot
Copy link

@ArkaSaha30: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pull-etcd-build
  • /test pull-etcd-unit-test
  • /test pull-etcd-verify

The following commands are available to trigger optional jobs:

  • /test pull-etcd-e2e-amd64
  • /test pull-etcd-integration-1-cpu-amd64

Use /test all to run all jobs.

In response to this:

/retest pull-etcd-integration-1-cpu-amd64

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ArkaSaha30
Copy link
Contributor Author

/test pull-etcd-integration-1-cpu-amd64

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @ArkaSaha30

Makefile Outdated Show resolved Hide resolved
@ArkaSaha30 ArkaSaha30 force-pushed the make-arch-builds branch 2 times, most recently from 125d47c to 836e83f Compare May 28, 2024 18:01
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @serathius and @ArkaSaha30.

@ivanvc
Copy link
Member

ivanvc commented May 28, 2024

Can we have an agreement on kubernetes/test-infra#32672 (comment) + #18083 (comment) before merging this PR? 😅

Makefile Outdated Show resolved Hide resolved
This commit will group similar targets as per
architecture into subtargets to build. It also adds
`build-all` target to build all OS-Arch cominations.

Allows subtargets without scripting
by parameterizing and optimizing OS-ARCH builds

Signed-off-by: ArkaSaha30 <[email protected]>
@serathius serathius merged commit f903a9b into etcd-io:main May 29, 2024
37 of 44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

8 participants