-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build subtargets based on ARCH #18083
Conversation
Hi @ArkaSaha30. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
We have two options,
|
/retest pull-etcd-integration-1-cpu-amd64 |
@ArkaSaha30: The
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-etcd-integration-1-cpu-amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @ArkaSaha30
125d47c
to
836e83f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @serathius and @ArkaSaha30.
Can we have an agreement on kubernetes/test-infra#32672 (comment) + #18083 (comment) before merging this PR? 😅 |
836e83f
to
78335c9
Compare
This commit will group similar targets as per architecture into subtargets to build. It also adds `build-all` target to build all OS-Arch cominations. Allows subtargets without scripting by parameterizing and optimizing OS-ARCH builds Signed-off-by: ArkaSaha30 <[email protected]>
78335c9
to
5202b6a
Compare
This PR will group similar targets as per architecture into subtargets to build. It also adds a
build-all
target to build all OS-ARCH combinations.Conversation: kubernetes/test-infra#32672 (comment)
Fixes: kubernetes/test-infra#32672
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.