Fix release git url & document lessons learned #17677
Conversation
From 2021-08-13, GitHub is no longer accepting account passwords when authenticating Git operations. You need to add a PAT (Personal Access Token) instead for HTTPS. We should intead keep things simple and just use ssh to push to GitHub. Signed-off-by: James Blair <[email protected]>
| @@ -61,7 +61,7 @@ main() { | |||
| REPOSITORY=$(pwd) | |||
| BRANCH=$(git rev-parse --abbrev-ref HEAD) | |||
| else | |||
| REPOSITORY=${REPOSITORY:-"https://github.com/etcd-io/etcd.git"} | |||
| REPOSITORY=${REPOSITORY:-"git@github.com:etcd-io/etcd.git"} | |||
There was a problem hiding this comment.
If this change is accepted I will backport it to release-3.4 and release-3.5.
There was a problem hiding this comment.
If this change is accepted I will backport it to
release-3.4andrelease-3.5.
It's OK to backport the change to release-3.5. But let's keep 3.4 as it's. I haven't seen any issues so far when releasing 3.4, we don't really want to any surprise.
There was a problem hiding this comment.
Fair enough. We haven't seen the issue because we have been manually creating and pushing tag.
There was a problem hiding this comment.
The scheme/protocol for cloning a repository can be a personal preference. If you have properly configured Git for HTTP authentication, it should work fine. You could potentially use GitHub without an SSH key.
That's why I think the scheme could be opinionated. Maybe a good middle ground would be to receive an option --use-https-repository-url (or --use-ssh-repository-url), to switch from https and ssh, and keep the release scripts more in sync... Or we could also leave it as-is, according to each release manager preference :)
Capturing lessons learned from etcd 3.5.13 release. Signed-off-by: James Blair <[email protected]>
jmhbnz
force-pushed
the
fix-release-issues
branch
from
262ed59 to
a9e4e2a
Compare
|
/retest Flake already reported. |
We recently released etcd
v3.5.13. This pull request captures lessons from the release to ensure future releases can be smoother.