tests/e2e: address golangci var-naming issues #17636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Valdes <[email protected]>
20 tasks
ivanvc
commented
Mar 22, 2024
Comment on lines
+160
to
162
| //revive:disable:var-naming | ||
| ClusterId uint64 `json:"cluster_id,string,omitempty"` | ||
| MemberId uint64 `json:"member_id,string,omitempty"` |
There was a problem hiding this comment.
Ignored these as they come from protobufs and this is unmarshalling the response.
ivanvc
commented
Mar 22, 2024
| } | ||
|
|
||
| func authTest_CVE_2021_28235(cx ctlCtx) { | ||
| func authTestCVE2021_28235(cx ctlCtx) { |
There was a problem hiding this comment.
I was hesitant about this rename. However, the original test case name retains the underscores to split the CVE name properly (TestAuth_CVE_2021_28235).
ivanvc
commented
Mar 22, 2024
| @@ -39,11 +39,11 @@ const ( | |||
| ) | |||
|
|
|||
| type testCase struct { | |||
| name string | |||
| client e2e.ClientConfig | |||
| clientHttpSerparate bool | |||
There was a problem hiding this comment.
Fixed a typo in the variable name too (Serparate -> Separate)
serathius
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the
var-namingissues intests/e2e.Part of #17578
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.