server: address golangci var-naming issues #17624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Valdes <[email protected]>
ivanvc
commented
Mar 21, 2024
Comment on lines
+122
to
+125
| //revive:disable:var-naming | ||
| func (s *storeRecorder) JsonStats() []byte { return nil } | ||
|
|
||
| //revive:enable:var-naming |
There was a problem hiding this comment.
Added this ignores, as it comes from v2's (*recorder) JsonStats().
ivanvc
commented
Mar 21, 2024
| @@ -26,7 +26,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| ENV_VERIFY_VALUE_LOCK verify.VerificationType = "lock" | |||
| EnvVerifyValueLock verify.VerificationType = "lock" | |||
There was a problem hiding this comment.
Even though this is exported, I just renamed it as it is used only by the backend_tests package, which is in the same directory but in a different package.
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses minor var-naming violations from the server directory.
Part of #17578
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.