Add patch version release criterion #17546
Conversation
| - Fixed one or more major CVEs (>=7.5). | ||
| - Fixed one or more critical bugs. | ||
| - Fixed three or more major bugs. | ||
| - Fixed five or more minor bugs. |
There was a problem hiding this comment.
We were in a situation last year where we had backported adopting new golang minor version and it took us quite a while to cut a patch release making it available for users. For some users/orgs using software compiled with modern / supported build chain is quite important.
| - Fixed five or more minor bugs. | |
| - Fixed five or more minor bugs. | |
| - A new golang major or minor version has been adopted. |
There was a problem hiding this comment.
A new golang major or minor version has been adopted.
This should be already covered by Fixed one or more major CVEs (>=7.5). If a new golang major or minor version doesn't have any CVE fixes, then we don't have to necessary release a patch version.
There was a problem hiding this comment.
My preference is it can still be worthwhile to cut the patch release even if there is no major CVE as some organisations want to always have software that is built with supported toolchains. When we backporting a golang minor release this does nothing to keep support until the patch release with that new minor version is cut.
Happy to defer to overall consensus and we can leave it for now.
There was a problem hiding this comment.
Yes, I agree there is a gray area. The criteria just defines some "hard" requirement. We have some flexibility for golang bumping case. If it has any CVE fixes, then it falls into the category "Fixed one or more major CVEs (>=7.5)". Otherwise, we can regard it as a major or minor fix.
But it's open to discussion, and the criteria isn't set of stone. We can always update when needed.
Signed-off-by: Benjamin Wang <[email protected]>
ahrtr
force-pushed
the
release_criteria_20240307
branch
from
1db8acf to
e5029a3
Compare
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
This is the first step to enhance our release process. We may propose to set up a dedicated release team or a pool of release person candidates in next step.
Please kindly let me know if you have any suggestion or comment on the patch release criterion. Thanks.
cc @jmhbnz @serathius @spzala