-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2024-03-04] Bump dependencies identified by dependabot #17543
Conversation
Hi @ivanvc. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
0468bc6
to
a85ff92
Compare
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks for helping us stay on top of these @ivanvc 🙏🏻
The workflow failure is caused by #17393 (comment) |
Please rebase this PR and bump google.golang.org/protobuf to 1.33.0 in this PR. |
Signed-off-by: Ivan Valdes <[email protected]>
Signed-off-by: Ivan Valdes <[email protected]>
Signed-off-by: Ivan Valdes <[email protected]>
Addresses CVE-2024-24786 (https://pkg.go.dev/vuln/GO-2024-2611) Signed-off-by: Ivan Valdes <[email protected]>
a85ff92
to
0c6b6ac
Compare
@ahrtr, done. I already bumped protobuf to 1.33.0 :) |
Thanks. Why the CVE |
Refer to https://github.com/protocolbuffers/protobuf-go/releases/tag/v1.33.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks
It seems like those two branches don't have the vulnerability check. I'll raise an issue and work on it shortly. I'll also bump protobuf there. |
Thank you! |
This pull request completes this week's etcd dependency updates following our dependency roster and dependency management instructions.
Summary of actions:
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.