Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024-03-04] Bump dependencies identified by dependabot #17543

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

@k8s-ci-robot
Copy link

Hi @ivanvc. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ivanvc ivanvc force-pushed the 20240304-dependency-updates branch 2 times, most recently from 0468bc6 to a85ff92 Compare March 6, 2024 19:34
@ivanvc ivanvc marked this pull request as ready for review March 6, 2024 19:35
@ivanvc
Copy link
Member Author

ivanvc commented Mar 6, 2024

Note that the Go Vulnerability Checker is still failing due to the Go 1.21.8 (#17539) 1.22.1 (#17393) update

@jmhbnz
Copy link
Member

jmhbnz commented Mar 6, 2024

/ok-to-test

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks for helping us stay on top of these @ivanvc 🙏🏻

@ahrtr
Copy link
Member

ahrtr commented Mar 7, 2024

The workflow failure is caused by #17393 (comment)

@ahrtr ahrtr mentioned this pull request Mar 7, 2024
@ahrtr
Copy link
Member

ahrtr commented Mar 7, 2024

Please rebase this PR and bump google.golang.org/protobuf to 1.33.0 in this PR.

@ivanvc ivanvc force-pushed the 20240304-dependency-updates branch from a85ff92 to 0c6b6ac Compare March 7, 2024 17:13
@ivanvc
Copy link
Member Author

ivanvc commented Mar 7, 2024

Please rebase this PR and bump google.golang.org/protobuf to 1.33.0 in this PR.

@ahrtr, done. I already bumped protobuf to 1.33.0 :)

@ahrtr
Copy link
Member

ahrtr commented Mar 7, 2024

Please rebase this PR and bump google.golang.org/protobuf to 1.33.0 in this PR.

@ahrtr, done. I already bumped protobuf to 1.33.0 :)

Thanks.

Why the CVE CVE-2024-24786 wasn't discovered by 3.5 and 3.4's workflow checks. Could you please raise an issue to followup this for 3.4 and 3.5? Thanks.

@ahrtr
Copy link
Member

ahrtr commented Mar 7, 2024

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks

@ivanvc
Copy link
Member Author

ivanvc commented Mar 7, 2024

Please rebase this PR and bump google.golang.org/protobuf to 1.33.0 in this PR.

@ahrtr, done. I already bumped protobuf to 1.33.0 :)

Thanks.

Why the CVE CVE-2024-24786 wasn't discovered by 3.5 and 3.4's workflow checks. Could you please raise an issue to followup this for 3.4 and 3.5? Thanks.

It seems like those two branches don't have the vulnerability check. I'll raise an issue and work on it shortly. I'll also bump protobuf there.

@ahrtr ahrtr merged commit 266a3ba into etcd-io:main Mar 7, 2024
40 checks passed
@ahrtr
Copy link
Member

ahrtr commented Mar 7, 2024

I'll raise an issue and work on it shortly. I'll also bump protobuf there.

Thank you!

@ivanvc ivanvc deleted the 20240304-dependency-updates branch March 7, 2024 18:58
@ivanvc
Copy link
Member Author

ivanvc commented Mar 8, 2024

I'll raise an issue and work on it shortly. I'll also bump protobuf there.

Thank you!

@ahrtr just a heads up that I created #17551 and #17549 to track these issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants