Translate v2 requests into v3 ClusterMemberAttrSetRequest and ClusterVersionSetRequest

[serathius]

From membership.Cluster perspective they are the same request, just using different path.

I remembered that v3 code does through authorization verification, so I have double checked that ClusterMemberAttrSet and ClusterVersionSet request don't require admin permissions as they are internal requests (not available via API). This means that this change will work even if authorization is enabled.

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[serathius]

cc @ahrtr @fuweid @chaochn47 @siyuanfoundation

[serathius]

/retest

[ahrtr]

You are working on #12913 PR by PR.
Can you provide a doc to summarize the plan so that all of us are on the same page on the overall picture? Or enhance the @ geesta 's doc?

• What you are going to do in 3.6?
• What you are planing to do in 3.7?

[serathius]

Plan was established long time ago in the top comment of #12913

On high level the plan is to clean up apply code until we can easily switch to membership information to v3. The main way to achieve that is by no longer applying any entries older than consistent index.

[ahrtr]

We need a detailed plan. No fancy documentation required, just provide a list of PRs you are going to do, and the purpose and simple description for each PR.

The task has existed for more than 2 years, and multiple people worked on it. Please don't expect everyone to keep all the context/details in mind at all times.

[serathius]

Plan:

• Refactor code until can clearly separate the membership state machine
  • Extract membership applier #17015
  • Extract applyEntry from apply #17016
  • Translate v2 requests into v3 ClusterMemberAttrSetRequest and ClusterVersionSetRequest #17008
• Allow raft to bootstrap without snapshot
• Switch membership state machine to bootstrap from v3 state and switch validation to v3.

[ahrtr]

Will revisit this PR after #17015 is merged, and this PR is rebased.

[ahrtr]

LGTM

Please rebase this PR and wait for workflow green before merging

[serathius]

Please rebase this PR and wait for workflow green before merging

Done

[serathius]

/retest

[serathius]

Will want to add some additional e2e test to avoid breaking things.

[serathius]

/retest

[fuweid]

LGTM

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr,serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 80.76923% with 5 lines in your changes missing coverage. Please review.

Project coverage is 68.79%. Comparing base (12b47c2) to head (9a78165).
Report is 79 commits behind head on main.

❗ Current head 9a78165 differs from pull request most recent head b781251

Please upload reports for the commit b781251 to get more accurate results.

Files with missing lines	Patch %	Lines
server/etcdserver/apply_v2.go	83.33%	4 Missing ⚠️
server/etcdserver/server.go	50.00%	1 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
server/etcdserver/server.go	82.16% <50.00%> (+0.98%)	⬆️
server/etcdserver/apply_v2.go	79.31% <83.33%> (+10.07%)	⬆️

... and 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #17008      +/-   ##
==========================================
+ Coverage   68.69%   68.79%   +0.10%     
==========================================
  Files         420      420              
  Lines       35532    35544      +12     
==========================================
+ Hits        24409    24453      +44     
+ Misses       9686     9661      -25     
+ Partials     1437     1430       -7     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12b47c2...b781251. Read the comment docs.

[k8s-ci-robot]

@serathius: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-etcd-unit-test	efae7e7	link	true	/test pull-etcd-unit-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[serathius]

/retest