Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RaftCluster boostrap being based on v3 store while apply is based on v2 store. #16655

Closed
wants to merge 1 commit into from

Conversation

serathius
Copy link
Member

Migration off v2 store was unfinished during v3.5 development #12914 leaving RaftCluster broken, half migrated. This was found in v3.5 and fixed in #13348, however this is was not patched on main branch.

This PR makes v3.6 RaftCluster consistent with v3.5 so we can cleanly migrate off v2 store.

… on v2 store.

Migration off v2 store was unfinished during v3.5 development etcd-io#12914 leaving RaftCluster broken, half migrated.
This was found in v3.5 and fixed in etcd-io#13348, however this is was not patched on main branch.

This PR makes v3.6 RaftCluster consistent with v3.5 so we can cleanly
migrate off v2 store.

Signed-off-by: Marek Siarkowicz <[email protected]>
@serathius
Copy link
Member Author

cc @ahrtr
This PR is to clarify issue with the current RaftCluster. Don't think we necessarily need to merge this PR.

@ahrtr
Copy link
Member

ahrtr commented Sep 27, 2023

I do not see any need to forward port #13348 to 3.6(main branch), as long as we are going to remove v2store in 3.6 [of course, we also need to generate v2 snapshot using v3 store]. It's also the reason why #13348 was resolved in 3.5 directly instead of the main branch.

There is one possibility that the Zombie members issue might be carried over to 3.6, when users upgrade 3.4 to 3.5.0 (instead of 3.5.1+), and then to 3.6. But it is unlikely in practice just #13196 (comment) mentions.

Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Mar 17, 2024
@serathius serathius closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants