Reuse check put

[serathius]

cc @ahrtr @jmhbnz
Built on #16517

[iraj720]

saw the tests just now
they are pointing to the same issue

[ahrtr]

The following logic shouldn't be part of checkPut.

	if req.IgnoreValue {
		val = prevKV.Value
	}
	if req.IgnoreLease {
		leaseID = lease.LeaseID(prevKV.Lease)
	} 
	if !req.PrevKv {
		return val, nil, leaseID, nil
	}

[serathius]

I can implement it that way, but it results in weird duplication of logic to check whether prevKV is needed.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@serathius: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-etcd-verify	c47203d	link	true	/test pull-etcd-verify
pull-etcd-unit-test-386	c47203d	link	true	/test pull-etcd-unit-test-386
pull-etcd-integration-1-cpu-arm64	c47203d	link	true	/test pull-etcd-integration-1-cpu-arm64
pull-etcd-unit-test-amd64	c47203d	link	true	/test pull-etcd-unit-test-amd64
pull-etcd-integration-4-cpu-amd64	c47203d	link	true	/test pull-etcd-integration-4-cpu-amd64
pull-etcd-unit-test-arm64	c47203d	link	true	/test pull-etcd-unit-test-arm64
pull-etcd-integration-2-cpu-amd64	c47203d	link	true	/test pull-etcd-integration-2-cpu-amd64
pull-etcd-integration-2-cpu-arm64	c47203d	link	true	/test pull-etcd-integration-2-cpu-arm64
pull-etcd-integration-4-cpu-arm64	c47203d	link	true	/test pull-etcd-integration-4-cpu-arm64
pull-etcd-integration-1-cpu-amd64	c47203d	link	true	/test pull-etcd-integration-1-cpu-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[codecov]

Codecov Report

Attention: Patch coverage is 77.50000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 64.55%. Comparing base (7bb5596) to head (c47203d).

Files with missing lines	Patch %	Lines
server/etcdserver/txn/txn.go	77.50%	4 Missing and 5 partials ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
server/etcdserver/txn/txn.go	84.07% <77.50%> (-9.08%)	⬇️

... and 104 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #16519      +/-   ##
==========================================
- Coverage   68.82%   64.55%   -4.28%     
==========================================
  Files         420      420              
  Lines       35623    35623              
==========================================
- Hits        24519    22996    -1523     
- Misses       9675    11133    +1458     
- Partials     1429     1494      +65     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bb5596...c47203d. Read the comment docs.