Update etcdutl restore to create v2 snapshot from v3 #16376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrtr
reviewed
Aug 5, 2023
tests/e2e/ctl_v3_snapshot_test.go
Outdated
| for i := range epc.Procs[0].Config().Args { | ||
| if epc.Procs[0].Config().Args[i] == "--data-dir" { | ||
| epc.Procs[0].Config().Args[i+1] = newDataDir | ||
| } | ||
| } | ||
|
|
||
| //Verify that initial snapshot is created by the restore operation | ||
| verifySnapshot(t, epc) |
There was a problem hiding this comment.
Can you also add a verification that the membership data read from the v2 snapshot is expected?
Signed-off-by: Geeta Gharpure <[email protected]>
ahrtr
reviewed
Aug 14, 2023
| for i := range epc.Procs[0].Config().Args { | ||
| if epc.Procs[0].Config().Args[i] == "--data-dir" { | ||
| epc.Procs[0].Config().Args[i+1] = newDataDir | ||
| } | ||
| } | ||
|
|
||
| // Verify that initial snapshot is created by the restore operation | ||
| verifySnapshotMembers(t, epc, membersBefore) |
There was a problem hiding this comment.
The cluster in this test case has only one member, please consider to add a case verify that the members read from the snapshot are also expected in multiple members cluster in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #12913
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.