-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] *: support online downgrade from 3.5 to 3.4 #15990
base: release-3.4
Are you sure you want to change the base?
Conversation
Signed-off-by: Bogdan Kanivets <[email protected]>
No changes to v3.4, as explained please change the |
@@ -637,3 +646,9 @@ func appendMarkTombstone(lg *zap.Logger, b []byte) []byte { | |||
func isTombstone(b []byte) bool { | |||
return len(b) == markedRevBytesLen && b[markBytePosition] == markTombstone | |||
} | |||
|
|||
// downgradeMetaBucket delete 3.5 specific keys to make backend fully compatible with 3.4 | |||
func downgradeMetaBucket(tx backend.BatchTx) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this part can be done using capabilities of new migrate
command from 3.6, cc @serathius
My understanding that |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions. |
Agreed during the community meeting that @siyuanfoundation will pick this up. |
Feel free to start a new PR, we can close this one. The goal was to showcase the idea. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Tested this by running 3.5 binary with benchmark (to generate load):
Then stopping and starting 3.4 binary one by one
Related to: #15878