Move consistent_index forward when executing alarmList operation #14419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Follow up #13854 |
ahrtr
force-pushed
the
alarm_list_ci
branch
2 times, most recently
from
c2ed9ec to
ed0841f
Compare
The alarm list is the only exception that doesn't move consistent_index
forward. The reproduction steps are as simple as,
```
etcd --snapshot-count=5 &
for i in {1..6}; do etcdctl alarm list; done
kill -9 <etcd_pid>
etcd
```
Signed-off-by: Benjamin Wang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #14419 +/- ##
==========================================
- Coverage 75.36% 75.22% -0.15%
==========================================
Files 457 457
Lines 37183 37182 -1
==========================================
- Hits 28024 27971 -53
- Misses 7398 7434 +36
- Partials 1761 1777 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
serathius
approved these changes
Sep 5, 2022
ahrtr
added a commit
to ahrtr/etcd
that referenced
this pull request
Sep 6, 2022
Cherry pick etcd-io#14419 to 3.5. Signed-off-by: Benjamin Wang <[email protected]>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/etcd
that referenced
this pull request
Oct 7, 2022
Cherry pick etcd-io#14419 to 3.5. Signed-off-by: Benjamin Wang <[email protected]>
tjungblu
pushed a commit
to tjungblu/etcd
that referenced
this pull request
Jul 26, 2023
Cherry pick etcd-io#14419 to 3.5. Signed-off-by: Benjamin Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #14382
The alarm list is the only exception that doesn't move consistent_index
forward. The reproduction steps are as simple as,
Signed-off-by: Benjamin Wang [email protected]
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.