server: Attempt to fix data corruption #13840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, I managed to reproduce the issue with this fix. So, this is not a correct fix at least on main branch. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13840 +/- ##
==========================================
- Coverage 72.54% 72.48% -0.07%
==========================================
Files 468 468
Lines 38222 38222
==========================================
- Hits 27730 27705 -25
- Misses 8709 8726 +17
- Partials 1783 1791 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Closing for #13844 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on git bisect I identified 5005167 as root cause (still not 100% confirmed). In this commit the only change I think could introduce the corruption content of
OnPreCommitUnsafe. Call to this method was introduced in https://github.com/etcd- io/etcd/pull/12855/commits/9f11b16b2dcab5922bed18b818b84fc1113f7e06 where it is called bycommitmethod.Overall I found it weird in #12855 that introduces both changes, fact that this refactor adds calls
indexer.UnsafeWriteoutside read lock, which doesn't match previous behavior. This is still guessing, and I haven't verified the fix, so I leave it up to author/reviewers of the original PR. cc @ptab