Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persists Term in the (bbolt) Backend #12964

Merged
merged 1 commit into from
May 14, 2021
Merged

Persists Term in the (bbolt) Backend #12964

merged 1 commit into from
May 14, 2021

Conversation

ptabor
Copy link
Contributor

@ptabor ptabor commented May 13, 2021

Additional layer of protection, that allows to validate whether we start replaying log not only from the proper 'index', but also of the
right 'term'.

Additional layer of protection, that allows to validate whether we
start replaying log not only from the proper 'index', but also of the
right 'term'.
Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Just making sure, these series of changes won't affect our compatibility right?

etcd 3.4 receiving snapshot from 3.5 with the new meta keys won't crash to parse snapshot, because those are just extra keys in bolt?

@ptabor
Copy link
Contributor Author

ptabor commented May 14, 2021

lgtm.

Just making sure, these series of changes won't affect our compatibility right?

etcd 3.4 receiving snapshot from 3.5 with the new meta keys won't crash to parse snapshot, because those are just extra keys in bolt?

Yes. We just add a new key so 3.5 -> 3.4 is safe: both during operations and/or rollback.
I also don't depend on the new data in any way and are prepared for the keys to not be set, so the transition 3.4 -> 3.5 is safe.

This data will be very handy for v3.6.

@ptabor ptabor merged commit eae7a84 into etcd-io:main May 14, 2021
@ptabor ptabor deleted the main branch May 14, 2021 04:35
@ptabor
Copy link
Contributor Author

ptabor commented May 14, 2021

FTR: Main goal: #12913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants