Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate V2 API: --enable-v2 and --experimental-enable-v2v3 issue a warning #12940

Merged
merged 1 commit into from
May 10, 2021

Conversation

ptabor
Copy link
Contributor

@ptabor ptabor commented May 10, 2021

Flags --experimental-enable-v2v3 and '-enable-v2' will raise a warning in 3.5,
in 3.6 they are schedule for decomissioning, such that v2store can stop be written in 3.7.

Deprecation plan in: #12913

@ptabor ptabor changed the title Deprecate V2 API: --enable-v2 and v2v3 Deprecate V2 API: --enable-v2 and --experimental-enable-v2v3 issue a warning May 10, 2021
@ptabor ptabor force-pushed the 20210510-v2-warnings branch 2 times, most recently from a5b478c to e4c7802 Compare May 10, 2021 13:02
CHANGELOG-3.5.md Outdated Show resolved Hide resolved
server/etcdmain/config.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2021

Codecov Report

Merging #12940 (e4c7802) into master (6bc125c) will decrease coverage by 0.15%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12940      +/-   ##
==========================================
- Coverage   73.09%   72.94%   -0.16%     
==========================================
  Files         430      430              
  Lines       34185    34187       +2     
==========================================
- Hits        24988    24936      -52     
- Misses       7257     7315      +58     
+ Partials     1940     1936       -4     
Flag Coverage Δ
all 72.94% <75.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/embed/config.go 70.52% <ø> (ø)
server/embed/etcd.go 76.37% <50.00%> (-0.12%) ⬇️
server/etcdmain/config.go 82.77% <100.00%> (ø)
server/etcdserver/api/rafthttp/peer_status.go 89.28% <0.00%> (-10.72%) ⬇️
pkg/netutil/routes_linux.go 40.56% <0.00%> (-9.44%) ⬇️
server/etcdserver/api/rafthttp/peer.go 77.41% <0.00%> (-9.04%) ⬇️
client/pkg/v3/fileutil/purge.go 66.03% <0.00%> (-7.55%) ⬇️
server/etcdserver/api/v3rpc/lease.go 74.64% <0.00%> (-5.64%) ⬇️
server/etcdserver/api/rafthttp/msgappv2_codec.go 67.88% <0.00%> (-3.67%) ⬇️
client/v3/experimental/recipes/key.go 72.13% <0.00%> (-3.28%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bc125c...e4c7802. Read the comment docs.

@ptabor ptabor force-pushed the 20210510-v2-warnings branch from e4c7802 to ecb324b Compare May 10, 2021 14:05
Flags `--experimental-enable-v2v3` and '-enable-v2' will raise a warning in 3.5,
in 3.6 they are schedule for decomissioning, such that v2store can stop be written in 3.7.

Deprecation plan in: etcd-io#12913
@ptabor ptabor force-pushed the 20210510-v2-warnings branch from ecb324b to 269f22c Compare May 10, 2021 14:20
Copy link
Contributor

@lilic lilic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ptabor ptabor merged commit e892d6d into etcd-io:master May 10, 2021
@ptabor ptabor deleted the 20210510-v2-warnings branch May 10, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants