Merge pull request #17652 from callthingsoff/make_Regexp_global

all: make regexp.Regexp variables global when not using configuration…

client/pkg/testutil/leak.go

@@ -34,17 +34,18 @@ running(leaking) after all tests.
 		...
 	}
 */
+var normalizedRegexp = regexp.MustCompile(`\(0[0-9a-fx, ]*\)`)
+
 func CheckLeakedGoroutine() bool {
 	gs := interestingGoroutines()
 	if len(gs) == 0 {
 		return false
 	}
 
 	stackCount := make(map[string]int)
-	re := regexp.MustCompile(`\(0[0-9a-fx, ]*\)`)
 	for _, g := range gs {
 		// strip out pointer arguments in first function of stack dump
-		normalized := string(re.ReplaceAll([]byte(g), []byte("(...)")))
+		normalized := string(normalizedRegexp.ReplaceAll([]byte(g), []byte("(...)")))
 		stackCount[normalized]++
 	}
 

etcdctl/ctlv3/command/util.go

@@ -56,9 +56,10 @@ func addHexPrefix(s string) string {
 	return string(ns)
 }
 
+var argsRegexp = regexp.MustCompile(`"(?:[^"\\]|\\.)*"|'[^']*'|[^'"\s]\S*[^'"\s]?`)
+
 func Argify(s string) []string {
-	r := regexp.MustCompile(`"(?:[^"\\]|\\.)*"|'[^']*'|[^'"\s]\S*[^'"\s]?`)
-	args := r.FindAllString(s, -1)
+	args := argsRegexp.FindAllString(s, -1)
 	for i := range args {
 		if len(args[i]) == 0 {
 			continue