do not call ApplyConfChange when validation failed

Signed-off-by: Benjamin Wang <[email protected]>
etcd-io · Nov 26, 2023 · d3b20d2 · d3b20d2
1 parent 9881db0
commit d3b20d2
Showing 1 changed file with 0 additions and 1 deletion.
diff --git a/server/etcdserver/server.go b/server/etcdserver/server.go
@@ -1937,7 +1937,6 @@ func removeNeedlessRangeReqs(txn *pb.TxnRequest) {
 func (s *EtcdServer) applyConfChange(cc raftpb.ConfChange, confState *raftpb.ConfState, shouldApplyV3 membership.ShouldApplyV3) (bool, error) {
 	if err := s.cluster.ValidateConfigurationChange(cc, shouldApplyV3); err != nil {
 		cc.NodeID = raft.None
-		s.r.ApplyConfChange(cc)
 
 		// The txPostLock callback will not get called in this case,
 		// so we should set the consistent index directly.