-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.3] Bump go version to 1.22.8 #837
Conversation
Signed-off-by: Agni <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nit: Can you split the commit into two, one for the golangcli-lint version update and another for Golang's?
Same applies to #836
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you split the commit into two, one for the golangcli-lint version update and another for Golang's?
Yes, I agree. But I won't insist on it for such minor changes, and we won't update the changelog for either change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per #837 (comment), this LGTM. Thanks, Agni.
Quick question, @ahrtr: did you manually approve the workflows for the pull request? I see it skipped the |
Yes, maintainers need to manually trigger workflow for first-time contributors. Please feel free to introduce ok-to-test mechanism to bbolt if you have time. thx |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ahrtr, ivanvc, PyAgni The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I forgot to follow up on this comment. We have it in place (#638), but I'm not sure why every new PR in the etcd repo has the needs-ok-to-test and not here. |
It seems that you did not get release-1.3 included in the list? bbolt/.github/workflows/gh-workflow-approve.yaml Lines 9 to 10 in 12280e0
|
Good catch. I'll open a PR and move the conversation there. |
etcd-io/etcd#18665