fix: change getCommand default format auto #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elbehery
force-pushed
the
getCommand_default_format_auto
branch
2 times, most recently
from
86d58d8 to
61627f5
Compare
|
@ahrtr I updated this accordingly, ptal 👍🏽 |
|
/assign @ahrtr |
|
@fuweid would appreciate your review :) |
fuweid
reviewed
Nov 8, 2023
| @@ -1064,7 +1064,7 @@ Additional options include: | |||
| --format | |||
| Output format. One of: `+FORMAT_MODES+` (default=bytes) | |||
| --parse-format | |||
| Input format (of key). One of: ascii-encoded|hex (default=ascii-encoded)" | |||
There was a problem hiding this comment.
There is no auto for parse-format to the input. So, I think we should not touch this line.
There was a problem hiding this comment.
good catch, my bad 👍🏽 thanks tons 🙏🏽
Signed-off-by: Mustafa Elbehery <[email protected]>
Elbehery
force-pushed
the
getCommand_default_format_auto
branch
from
61627f5 to
987e20b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes getCommand default format from ascii-encoded to auto
resolves ##588
cc @ahrtr