Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adapts to Android 14 #571

Merged
merged 1 commit into from
Oct 5, 2023
Merged

feat: adapts to Android 14 #571

merged 1 commit into from
Oct 5, 2023

Conversation

monkeyWie
Copy link
Contributor

@monkeyWie monkeyWie commented Sep 21, 2023

Hi, this PR is fix for #558, and I created a repository to reproduce it, refer to https://github.com/monkeyWie/bbolt-test

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @monkeyWie - Thanks for putting this together. Can you please ensure your commit is signed so your contribution can be accepted, i.e:

git rebase --signoff HEAD~1

git push --force

As a more general comment, how do we have assurance moving forward that the android side of this will continue to work as expected. Is there some way we can excercise this with meaningful tests?

@monkeyWie
Copy link
Contributor Author

I've already signed it, and regarding testing on Android, maybe we can add test cases on github action.

@ahrtr
Copy link
Member

ahrtr commented Sep 22, 2023

Have you verified the PR on Android?

@monkeyWie
Copy link
Contributor Author

@ahrtr Sure, I modified go.mod to replace go.etcd.io/bbolt with github.com/monkeyWie/bbolt and it tested fine, no crashes on Android 14.

@ahrtr
Copy link
Member

ahrtr commented Sep 22, 2023

LGTM

Note: The new file is almost identical to https://github.com/etcd-io/bbolt/blob/master/bolt_solaris.go.

@ahrtr ahrtr merged commit db45d0d into etcd-io:master Oct 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants