"Confinement" de la librairie Timex #4385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thbar
added
the
dette technique
thbar
commented
Dec 16, 2024
AntoineAugusti
approved these changes
Dec 16, 2024
|
Merci @AntoineAugusti ! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Le merge a échoué avec cette erreur:
Je relance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timex est une dépendance de 10k lignes qui a à l'origine été créée pour remplir un manque dans le langage Elixir. Sa maintenance semble avoir ralenti, et entre temps le langage a pour partie rattrapé son retard.
Dans cette PR, j'isole les appels à
Timexdans un moduleTimeWrapper, sans chercher pour le moment à supprimer l'usage deTimexdirectement.J'ajoute une règle Credo pour nous encourager à éviter son usage, sachant qu'on utilise que quelques appels et qu'ils seraient remplaçables à peu de frais.