Requêteur SIRI : corrige requête EstimatedTimetable (#3508)

etalab · Oct 5, 2023 · 7e7b1f3 · 7e7b1f3
1 parent 95cb969
commit 7e7b1f3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 15 deletions.
diff --git a/apps/transport/lib/siri_queries.ex b/apps/transport/lib/siri_queries.ex
@@ -78,22 +78,14 @@ defmodule Transport.SIRI do
     Saxy.encode!(doc)
   end
 
-  def build_line_refs(line_refs) do
-    # NOTE: we'll switch to proper well-escaped XML building later, this is research code
-    line_refs = line_refs |> Enum.map_join("\n", &"<siri:LineRef>#{&1}</siri:LineRef>")
-
-    """
-    <siri:Lines>
-      #{line_refs}
-    </siri:Lines>
-    """
-  end
-
   def line_refs_element([] = _line_refs), do: nil
 
   def line_refs_element(line_refs) do
-    line_refs = line_refs |> Enum.map(&element("siri:LineRef", [], &1))
-    element("siri:Lines", [], line_refs)
+    line_refs = Enum.map(line_refs, &element("siri:LineRef", [], &1))
+
+    element("siri:Lines", [], [
+      element("siri:LineDirection", [], line_refs)
+    ])
   end
 
   def append_if_not_nil(list, nil), do: list

diff --git a/apps/transport/test/transport/siri_queries_test.exs b/apps/transport/test/transport/siri_queries_test.exs
@@ -125,8 +125,10 @@ defmodule Transport.SIRITest do
               <siri:RequestTimestamp>#{timestamp}</siri:RequestTimestamp>
               <siri:MessageIdentifier>#{message_identifier}</siri:MessageIdentifier>
               <siri:Lines>
-                <siri:LineRef>#{line_001}</siri:LineRef>
-                <siri:LineRef>#{line_002}</siri:LineRef>
+                <siri:LineDirection>
+                  <siri:LineRef>#{line_001}</siri:LineRef>
+                  <siri:LineRef>#{line_002}</siri:LineRef>
+                </siri:LineDirection>
               </siri:Lines>
             </Request>
             <RequestExtension/>