Skip to content

Commit

Permalink
Update commands.lua
Browse files Browse the repository at this point in the history
this command would break if someone leaves and would 
stop counting at the first nil value in the list. 

you can get the length of the table to get the online players message in front but that would be less performant.
  • Loading branch information
Arctos2win authored Aug 21, 2023
1 parent 844d0f2 commit 77cbe8d
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions [core]/es_extended/server/commands.lua
Original file line number Diff line number Diff line change
Expand Up @@ -574,11 +574,11 @@ ESX.RegisterCommand("noclip", 'admin', function(xPlayer)
end, false)

ESX.RegisterCommand('players', "admin", function()
local xPlayers = ESX.GetExtendedPlayers() -- Returns all xPlayers
print(('^5%s^2 online player(s)^0'):format(#xPlayers))
for i = 1, #(xPlayers) do
local xPlayer = xPlayers[i]
print(('^1[^2ID: ^5%s^0 | ^2Name : ^5%s^0 | ^2Group : ^5%s^0 | ^2Identifier : ^5%s^1]^0\n'):format(
xPlayer.source, xPlayer.getName(), xPlayer.getGroup(), xPlayer.identifier))
end
local xPlayers = ESX.GetExtendedPlayers() -- Returns all xPlayers
local count = 0
for _, xPlayer in pairs(xPlayers) do
count += 1
print(('^1[^2ID: ^5%s^0 | ^2Name : ^5%s^0 | ^2Group : ^5%s^0 | ^2Identifier : ^5%s^1]^0\n'):format(xPlayer.source, xPlayer.getName(), xPlayer.getGroup(), xPlayer.identifier))
end
print(('^5%s^2 online player(s)^0'):format(count))
end, true)

0 comments on commit 77cbe8d

Please sign in to comment.