refactor: how to build path in reader #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fursich
reviewed
Aug 3, 2024
There was a problem hiding this comment.
@Konippi thanks for your contribution!
As for CI, I drafted up another PR to fix it (sorry for that).
Once it is getting merged, please rebase the latest master, and it should be fine.
Thank you for your patience in advance :)
| .map(PathBuf::from) | ||
| .unwrap_or_default() | ||
| .join(base_dir) | ||
| .join(filename); |
There was a problem hiding this comment.
I understand.
Looking forward to having your pr merged!
kenkoooo
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve and Simplify Path Construction Logic
This PR enhances and simplifies the path construction logic in the
build_pathfunction.unwrap_or_default()for concise fallback handling when the environment variable is not present.joinmethod for efficient concatenation of the base directory and filename.