Include two stages docker #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @JorritSalverda |
JorritSalverda
requested changes
Oct 19, 2020
| RUN go mod download \ | ||
| && go build ./... | ||
|
|
||
| FROM debian:buster-slim |
There was a problem hiding this comment.
The runtime image should still be scratch in order to reduce attack surface and size.
There was a problem hiding this comment.
I could not make it run with scratch. I figure out that for some reason does not like the
COPY --from=build /etc/ssl/certs/ca-certificates.crt /etc/ssl/certs/
Dockerfile
Outdated
| && apt-get -qqq -y install ca-certificates\ | ||
| && update-ca-certificates | ||
|
|
||
| RUN go mod download \ |
There was a problem hiding this comment.
Although it's nice to be able to build the application inside the dockerfile so you can run all of it locally, I'd rather do this inside the separate stage in the .estafette.yaml file, because it gives better visibility inside the Estafette GUI of how much time it takes, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building image, you need a ca-certificates.
I think this could be a good improve in order to not need to got this file in local.
Thanks!