Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse DLT network-trace prefix for SOME/IP messages #2116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kruss
Copy link
Collaborator

@kruss kruss commented Oct 10, 2024

This PR will add information from the DLT network-trace prefix to the resulting SOME/IP information being displayed.

In DLT network-traces for SOME/IP the DLT payload contains of two arguments, where the first argument is a prefix with additional information on the actual SOME/IP message in the the second argument.

For the implementation the prefix will be expected to consist of:

  • 4 bytes as IPv4 address
  • 2 bytes as udp/tcp port
  • 1 byte as protocol type (0 = local, 1 = tcp, 2 = udp)
  • 1 byte as message direction (0 = incoming, 1 = outgoing)
  • 1, 2 or 4 bytes as SOME/IP instance-id

@kruss kruss force-pushed the parse_dlt_network_trace_prefix branch 2 times, most recently from 572b4f3 to 8875d93 Compare October 10, 2024 22:47
@kruss kruss force-pushed the parse_dlt_network_trace_prefix branch from 8875d93 to 521847a Compare October 10, 2024 23:29
@DmitryAstafyev
Copy link
Collaborator

Requires discussion with @marcmo . In one hand this is not related to Some/IP parser directly and looks like cannot be a part of Some/IP parser; at the same time it's related to DLT parser, but not related to DLT protocol directly; but adding deep parsing operations into chipmunk directly is something, what we didn't do before. Let's discuss it.

@DmitryAstafyev
Copy link
Collaborator

DmitryAstafyev commented Oct 11, 2024

@kruss just as a mind. Could it be an optional feature of some of the parsers? Does it make sense?

@kruss kruss force-pushed the parse_dlt_network_trace_prefix branch from 521847a to ce80803 Compare October 28, 2024 10:25
@kruss kruss force-pushed the parse_dlt_network_trace_prefix branch from ce80803 to a7c6283 Compare October 30, 2024 16:14
@kruss
Copy link
Collaborator Author

kruss commented Oct 30, 2024

@kruss just as a mind. Could it be an optional feature of some of the parsers? Does it make sense?

As it's not related to the protocol specifications of either DLT or SOME/IP it does imo not make sense. Probably this code could be moved to application/apps/indexer/addons in chipmunk?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants