-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding weekly totals and fixing closed counters #18
base: gh-pages
Are you sure you want to change the base?
Conversation
@daonb you might want to set the org back to |
I thought you'd like that… That's the first thing the readme told me to |
Yeah, there will be in the future. Mind, this whole thing was created in a hack session :) |
It's very impressive. If I change the organization I won't be able to use |
@daonb You're probably better off using your own fork - http://hasadna.github.io/ubersicht/ |
@daonb That's actually a great idea! |
@daonb I just implemented your idea with the github.io subdomain, thanks a lot for that. Ubersicht will now use the gh subdomain, if it exists, and if no default organisation name is provided to override it. Back to your pull request: thanks a lot for the work, but I'm afraid I cant merge it because clicking the weekly indicators you added still shows the results for the past 24 hours, and not for the past 7 days. Also, they don't behave responsively: Sorry :/ But say, would it be useful to you if you could configure the time range used for the two indicators and the "last 24 hours only"-checkbox? So you could have them use 48 hours, or 7 days, or a month? Or do you want both the 24h and the 7 day indicators at once? |
I like the idea of showing the next bigger range if the current is 0 and hiding the 0 ones. |
Oooh, fancy. I like it. |
This reverts commit b371ee1.
…pages Conflicts: script/main.js
Sorry for the bugs. Should be fixed now. |
Interests |
Great project, thanks! Our organization is a bit slow so the 24h counters were at 0 so I added weekly counters and hidden the 24h if they are at 0.
Benny