Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding weekly totals and fixing closed counters #18

Open
wants to merge 9 commits into
base: gh-pages
Choose a base branch
from

Conversation

daonb
Copy link

@daonb daonb commented Mar 5, 2014

Great project, thanks! Our organization is a bit slow so the 24h counters were at 0 so I added weekly counters and hidden the 24h if they are at 0.

Benny

@svnlto
Copy link
Contributor

svnlto commented Mar 6, 2014

@daonb you might want to set the org back to hoodiehq :)

@daonb
Copy link
Author

daonb commented Mar 6, 2014

I thought you'd like that… That's the first thing the readme told me to
do.
Seriously, there has to be a better way to set the default organization.

@svnlto
Copy link
Contributor

svnlto commented Mar 6, 2014

Seriously, there has to be a better way to set the default organization.

Yeah, there will be in the future. Mind, this whole thing was created in a hack session :)

@daonb
Copy link
Author

daonb commented Mar 6, 2014

It's very impressive. If I change the organization I won't be able to use
it for hasadna. Maybe we should get the organization from the url's domain
if it's like xyz.github.io and hoodiehq if it's not under github.io?

@chrisdwheatley
Copy link

@daonb You're probably better off using your own fork - http://hasadna.github.io/ubersicht/

@espy
Copy link
Owner

espy commented Mar 6, 2014

@daonb That's actually a great idea!

@espy
Copy link
Owner

espy commented Mar 6, 2014

@daonb I just implemented your idea with the github.io subdomain, thanks a lot for that. Ubersicht will now use the gh subdomain, if it exists, and if no default organisation name is provided to override it.

Back to your pull request: thanks a lot for the work, but I'm afraid I cant merge it because clicking the weekly indicators you added still shows the results for the past 24 hours, and not for the past 7 days. Also, they don't behave responsively:

ubersicht_weekly_ipad

Sorry :/ But say, would it be useful to you if you could configure the time range used for the two indicators and the "last 24 hours only"-checkbox? So you could have them use 48 hours, or 7 days, or a month? Or do you want both the 24h and the 7 day indicators at once?

@janl
Copy link
Collaborator

janl commented Mar 6, 2014

I like the idea of showing the next bigger range if the current is 0 and hiding the 0 ones.

@espy
Copy link
Owner

espy commented Mar 6, 2014

Oooh, fancy. I like it.

@daonb
Copy link
Author

daonb commented Mar 12, 2014

Sorry for the bugs. Should be fixed now.

@lycon2014
Copy link

Interests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants