Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inputs): add fallback to ENV for inputs JIRA_COMPONENT and JIRA_TASK #28

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

tomassebestik
Copy link
Member

@tomassebestik tomassebestik commented Dec 6, 2024

Description

The Jira component defined in the target project workflow doesn't take effect (sync runs, but ticket created with empty component).

In our target projects, workflows are mostly set as ENV, but the action file (action.yml) is missing a fallback option for reading the value of JIRA_COMPONENT from ENV (same for JIRA_ISSUE_TYPE).

This is a quick patch. The entire GitHub Action is planned for a complete refactor very soon.

Related

@tomassebestik tomassebestik added the Type: Bug Bug in sync-jira-actions label Dec 6, 2024
@tomassebestik tomassebestik self-assigned this Dec 6, 2024
@tomassebestik tomassebestik requested a review from a team as a code owner December 6, 2024 06:51
@tomassebestik tomassebestik requested review from hfudev and removed request for a team December 6, 2024 06:51
Copy link

github-actions bot commented Dec 6, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello tomassebestik, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against a62c766

Copy link

@wujiangang wujiangang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomassebestik tomassebestik merged commit 9fb5d1a into v1 Dec 6, 2024
4 checks passed
@tomassebestik tomassebestik deleted the fix/component-input branch December 6, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug in sync-jira-actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants