Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate JIRA actions to own repo #1

Merged
merged 3 commits into from
Feb 14, 2024
Merged

Migrate JIRA actions to own repo #1

merged 3 commits into from
Feb 14, 2024

Conversation

tomassebestik
Copy link
Member

@tomassebestik tomassebestik commented Feb 7, 2024

NOTE: Code on default branch (v1) is the original (same) code from repo espressif/github-actions. Doing PR over it to have a basis for reviewing the code changes made in this migration process.


  • Soft refactored Python files; the original code is outdated but functional. Further refactoring opportunities exist, if we decide to do it.
  • Simplified the Dockerfile, removing unnecessary statements; more fixed base image
  • latest Debian in base image (Bookworm), latest node (20), Python 3.11
  • Added helper tools (Black, Pylint, Ruff) via pre-commit hooks.
  • pyproject.toml as single definition project point
  • Commitizen for automatic changelog
  • Removed ShellCheck GitHub Actions as they are not relevant to this repo.
  • removed old tests (wasn't working anyway), replaced by pytest tests + coverage - TODO: tests should be extended after proper refactoring
  • Autogenerated requirements.txt file by pre-commit hook
  • rewritten docs in README
  • Added Contributing Guide, linked from Danger bot comment output

Tested

Related

  • RDT-677

@tomassebestik tomassebestik self-assigned this Feb 7, 2024
@tomassebestik tomassebestik force-pushed the refactor/single-repo branch 9 times, most recently from 7533c78 to 08d2dad Compare February 9, 2024 06:53
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@tomassebestik tomassebestik force-pushed the refactor/single-repo branch 18 times, most recently from bbed778 to f0949c5 Compare February 9, 2024 10:14
Copy link
Collaborator

@dobairoland dobairoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/python-test.yml Outdated Show resolved Hide resolved
sync_jira_actions/sync_pr.py Outdated Show resolved Hide resolved
@tomassebestik tomassebestik force-pushed the refactor/single-repo branch 2 times, most recently from 27d40f1 to 5a387d6 Compare February 12, 2024 13:56
…e20)

- refactor(tests): add tests and GH workflow for pytest
- refactor: move source code to src directory
@tomassebestik tomassebestik force-pushed the refactor/single-repo branch 2 times, most recently from 38854b0 to 21ee9ae Compare February 13, 2024 07:15
- add commitizen support to pyproject.toml
- add Danger for GitHub
- add pre-commit hook for codespell
- add pre-commit hook prettier - formatting Markdown files
- add pre-commit workflow to CI
.gitignore Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@tomassebestik tomassebestik force-pushed the refactor/single-repo branch 2 times, most recently from 76add90 to b9425a2 Compare February 14, 2024 07:25
@tomassebestik tomassebestik merged commit b82419e into v1 Feb 14, 2024
4 checks passed
@tomassebestik tomassebestik deleted the refactor/single-repo branch February 14, 2024 08:02
@tom-borcin tom-borcin added Resolution: Done Issue is done internally Status: Done Issue is done internally and removed Status: Reviewing Issue is being reviewed labels Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants