-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added skip_if_soc marker for idf target #327
base: main
Are you sure you want to change the base?
Conversation
f1e6965
to
4a19463
Compare
4a19463
to
f5e1dd5
Compare
@@ -33,6 +33,7 @@ requires-python = ">=3.7" | |||
dependencies = [ | |||
"pytest-embedded~=1.12.1", | |||
"esp-idf-panic-decoder", | |||
"idf-build-apps~=2.5.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This additional dependency is a bit annoying, because:
- pytest-embedded version usually changes depending on IDF version (due to constraint files)
- at the same time, we try to keep idf-build-apps version the same for a long time, building the component with multiple IDF versions
So if in the future we have:
- IDF 6.0, which forces pytest-embedded>=2, which requires idf-build-apps>=3
- IDF 5.5, which forces pytest-embedded<2, which requires idf-build-apps<3
then we can't have a single version of idf-build-apps which satisfies both versions of IDF.
If you just need the "if_parser" functionality, can we split it into a separate pypi package?
import pytest | ||
from idf_build_apps.constants import SUPPORTED_TARGETS | ||
|
||
@pytest.mark.skip_if_soc("SOC_ULP_LP_UART_SUPPORTED == 1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are more complex conditions supported, or do we have the same limitation as in idf-build-apps, where we can't write A == 1 or B == 2 or C == 3
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. I'll fix this limitation together while moving the if parser to a separate package.
Description
This PR introduces a
skip_if_soc
marker that helps filter targets based on theirSOC_CAPS.h
attributes.Related
Closes #326
Testing
Checklist
Before submitting a Pull Request, please ensure the following: