Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements on NuttX app. Add tests for multiple use cases. (RDT-1038) #323

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

fdcavalcanti
Copy link
Contributor

@fdcavalcanti fdcavalcanti commented Nov 28, 2024

Description

This PR moves the _get_binary_target_info method to the NuttxSerial(EspSerial) class, since it is only used on Espressif Devices.
Also:

  • Remove the 'target' option from the app class (it is not required since we can use the target fixture).
  • Add some test cases.

Related

Testing

Added tests for general use and also QEMU.


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@fdcavalcanti fdcavalcanti force-pushed the feature/nuttx-and-qemu-support branch from 2bf69be to 373fa8f Compare November 28, 2024 13:17
@hfudev
Copy link
Member

hfudev commented Nov 29, 2024

the test cases are failing and I'm afraid it's not a false alarm this time. could you help take a look?

@github-actions github-actions bot changed the title Improvements on NuttX app. Add tests for multiple use cases. Improvements on NuttX app. Add tests for multiple use cases. (RDT-1038) Nov 29, 2024
@fdcavalcanti
Copy link
Contributor Author

Does the CI support testing on ESP32S3?

@hfudev
Copy link
Member

hfudev commented Nov 29, 2024

Does the CI support testing on ESP32S3?

no for ARM runners. the ARM runners only have esp32, esp32s2, and esp32c3 connected.

could you make the tests run with one of these targets? s2 shall also work?

@fdcavalcanti
Copy link
Contributor Author

Ok, I did not know that.
I'll just switch to ESP32, no problem.

@fdcavalcanti fdcavalcanti force-pushed the feature/nuttx-and-qemu-support branch from 373fa8f to 73d5945 Compare November 29, 2024 11:05
@fdcavalcanti fdcavalcanti force-pushed the feature/nuttx-and-qemu-support branch from 73d5945 to 9677f62 Compare November 29, 2024 11:50
@hfudev hfudev merged commit 0550008 into espressif:main Nov 29, 2024
5 checks passed
@hfudev
Copy link
Member

hfudev commented Nov 29, 2024

Thanks for the PR. Merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants