fix/flash port #298
Merged
fix/flash port #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ac8e2cc.
hfudev
reviewed
Jul 29, 2024
|
The new approach LGTM! |
hfudev
reviewed
Jul 30, 2024
hfudev
reviewed
Jul 30, 2024
horw
force-pushed
the
fix/flash-port
branch
2 times, most recently
from
8610a7c to
7a52c80
Compare
hfudev
reviewed
Jul 31, 2024
|
Thank you! LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this MR, I have changed logic for flash port