feat: add support for efuse in qemu #291
Conversation
|
@hfudev Hello! This MR has added support for qemu efuse. |
|
@igrr PTAL, thanks! |
| '-global', | ||
| f'driver=nvram.{self.app.target}.efuse,property=drive,value=efuse', | ||
| '-serial', | ||
| f'tcp::{available_port},server,nowait', |
There was a problem hiding this comment.
When launching QEMU and expecting that it should communicate with another application, it is better to use -daemonize flag — as recommended by QEMU documentation. Otherwise there may be a race condition between QEMU getting ready to accept TCP connections and the launch of the other application. It seems child.expect('qemu') aims to work around that, but I am not sure this is reliable enough.
There was a problem hiding this comment.
Also, now that I'm thinking of this... don't you end up with two QEMU processes running at the same time, and accessing the same eFuse file?.. One QEMU process is already launched when dut is created, another one is launched here.
| f.write(QEMU_DEFAULT_EFUSE[self.app.target]) | ||
| qemu_extra_args += [ | ||
| '-global', | ||
| f'driver={self.app.target}.gpio,property=strap_mode,value=0x08', |
There was a problem hiding this comment.
strap_mode is dependent on the chip target, please search for strap_mode in IDF's qemu_ext.py.
| '00000000000000000000000000000000000000000000000000000000000000000000000000000000' | ||
| '00000000' | ||
| ), | ||
| 'esp32c3': binascii.unhexlify( |
There was a problem hiding this comment.
We also support ESP32-S3 now, please add it as well.
Closes #269