feat: remove cache file when tests pytest-embedded itself (RDT-602) #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfudev
requested changes
Nov 27, 2023
conftest.py
Outdated
| @@ -18,6 +18,14 @@ def copy_fixtures(testdir): | |||
| yield | |||
|
|
|||
|
|
|||
| @pytest.fixture(autouse=True, scope='session') | |||
There was a problem hiding this comment.
scope should be function?
clear the cache between the test cases.
There was a problem hiding this comment.
I changed it to the function scope, but I'm confused by some logs. I think there might be conflicts because the cache is set to session.
horw
force-pushed
the
feat/cache_file_remove_conftest
branch
from
ab309dc to
a8b5d5a
Compare
horw
force-pushed
the
feat/cache_file_remove_conftest
branch
from
a1db685 to
a8b5d5a
Compare
|
Thank you for your PR @horw I've removed the |
github-actions
bot
changed the title
|
Closes #238 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the cache to make testing pytest-embedded more stable.