-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[idf] Support Skip Marker for ESP-IDF Soc Caps (RDT-1055) #326
Comments
@hfudev Hi, I can do it, WDYT? |
Should we also support the @pytest.mark.custom_skip(
("SOC_ADC_SAMPLE_FREQ_THRES_HIGH == 20000", "SUPPORT_A_FEATURE == 1"),
"SOC_ADC_SAMPLE_FREQ_THRES_HIGH == 10000",
include_preview_targets=True
) @pytest.mark.custom_skip(
"SOC_ADC_SAMPLE_FREQ_THRES_HIGH == 20000 and SUPPORT_A_FEATURE == 1",
"SOC_ADC_SAMPLE_FREQ_THRES_HIGH == 10000",
include_preview_targets=True
) |
The easiest part was |
sure it makes sense |
Soc Caps defines hardware capabilities or ESP-IDF apps.
Ideal Use Case
1. Basic
Support a marker, like
@pytest.mark.skip_if_soc("SOC_ADC_SAMPLE_FREQ_THRES_HIGH == 20000")
Iterate through all supported targets, if the expression is false, then we skip running the test case for this target.
2. Preview Targets
Support iterating through preview targets as well, by
Here we shall iterate over
SUPPORTED_TARGETS + PREVIEW_TARGETS
3. Limited Targets
Or iterate over a subset of targets, if user specified
targets
as param, likehere shall only iterate over esp32 and esp32s2
Implementation Details
idf_build_apps.manifest.if_parser
pytest_collection_modifyitems
idf-build-apps
shall be added as a dependency forpytest-embedded-idf
SUPPORTED_TARGETS
andPREVIEW_TARGETS
could be loaded fromidf_build_apps
. These values are lazy loaded from IDF_PATH.The text was updated successfully, but these errors were encountered: