Docs/add 3dp case (AIV-696) #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 11, 2024 19:11
wujiangang
reviewed
May 20, 2024
| @@ -28,6 +28,7 @@ | |||
| - [5.2. Schematic](#52-schematic) | |||
| - [5.3. PCB Layout](#53-pcb-layout) | |||
| - [5.4. Dimensions](#54-dimensions) | |||
| - [5.5 3D Printed Case](#55-3d-printed-case) | |||
There was a problem hiding this comment.
5.5 -> 5.5., follow the upper rule. Same in chinese version.
|
|
||
| || | ||
| |:--:| | ||
| |ESP32-S3-EYE - Case 3D printed on BambuLab P1S| |
There was a problem hiding this comment.
We can provide a link for BambuLab P1S.
|
|
||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Remove multiple empty lines to clean up the document.
|
LGTM. Please squash the commits into a single one in the final stage. |
Fixed typo in formating, removed spacing, added URL for Bambulab P1S for both EN and CN. |
|
@kaitkj , @wujiangang , thanks for your PR, I will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.