Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ws_transport): fix server-key corruption when first fragment lost… (IDFGH-12742) #13724

Closed
wants to merge 1 commit into from
Closed

fix(ws_transport): fix server-key corruption when first fragment lost… (IDFGH-12742) #13724

wants to merge 1 commit into from

Conversation

bryghtlabs-richard
Copy link
Contributor

… during websocket connection

Fixes 2267d4b
Fixes espressif/esp-protocols#396

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 30, 2024 •
edited
Loading

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello bryghtlabs-richard, we appreciate your contribution to this project!

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.
🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.
Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against 0ad9568

@bryghtlabs-richard
fix(ws_transport): fix server-key corruption
0ad9568 
When first fragment is sent over HTTP during websocket
connection, defer buffering of fragment until after the
websocket server-key is validated.

This order is required because the first fragment buffering
overwrites the memory holding the server-key headers.

Fixes 2267d4b
Fixes espressif/esp-protocols#396
@espressif-bot espressif-bot added the Status: Opened Issue is new label Apr 30, 2024
@github-actions github-actions bot changed the title fix(ws_transport): fix server-key corruption when first fragment lost… fix(ws_transport): fix server-key corruption when first fragment lost… (IDFGH-12742) Apr 30, 2024
@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels May 3, 2024
@bryghtlabs-richard
Copy link
Contributor Author

This is ready for review.

@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed and removed Status: In Progress Work is in progress labels May 20, 2024
espressif-bot pushed a commit that referenced this pull request May 23, 2024
@bryghtlabs-richard @suren-gabrielyan-espressif
fix(ws_transport): fixed server-key corruption
021dc87 
When first fragment is sent over HTTP during websocket
connection, defer buffering of fragment until after the
websocket server-key is validated.

This order is required because the first fragment buffering
overwrites the memory holding the server-key headers.

Fixes 2267d4b
Fixes espressif/esp-protocols#396
PR #13724
espressif-bot pushed a commit that referenced this pull request May 25, 2024
@bryghtlabs-richard @suren-gabrielyan-espressif
fix(ws_transport): fixed server-key corruption
10a2c2c 
When first fragment is sent over HTTP during websocket
connection, defer buffering of fragment until after the
websocket server-key is validated.

This order is required because the first fragment buffering
overwrites the memory holding the server-key headers.

Fixes 2267d4b
Fixes espressif/esp-protocols#396
PR #13724
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Reviewing Issue is being reviewed labels May 29, 2024
@bryghtlabs-richard bryghtlabs-richard deleted the fix/websocket_first_packet_3 branch June 5, 2024 16:24
espressif-bot pushed a commit that referenced this pull request Aug 21, 2024
@bryghtlabs-richard @euripedesrocha
fix(ws_transport): fixed server-key corruption
c42cfe1 
When first fragment is sent over HTTP during websocket
connection, defer buffering of fragment until after the
websocket server-key is validated.

This order is required because the first fragment buffering
overwrites the memory holding the server-key headers.

Fixes 2267d4b
Fixes espressif/esp-protocols#396
PR #13724
espressif-bot pushed a commit that referenced this pull request Aug 22, 2024
@bryghtlabs-richard @euripedesrocha
fix(ws_transport): fixed server-key corruption
a97a796 
When first fragment is sent over HTTP during websocket
connection, defer buffering of fragment until after the
websocket server-key is validated.

This order is required because the first fragment buffering
overwrites the memory holding the server-key headers.

Fixes 2267d4b
Fixes espressif/esp-protocols#396
PR #13724
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gabsuren gabsuren

Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

websocket client loses first text message when packed together with http response (IDFGH-11300)
3 participants
@bryghtlabs-richard @gabsuren @espressif-bot