Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Help command parameter for displaying only a specific command (IDFGH-10725) #11945

Closed
wants to merge 2 commits into from

Conversation

jnorgan
Copy link
Contributor

@jnorgan jnorgan commented Jul 24, 2023

This adds a capability to filter the Help command output in ESP Console as described by #11591.

@CLAassistant
Copy link

CLAassistant commented Jul 24, 2023

CLA assistant check
All committers have signed the CLA.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Jul 24, 2023
@github-actions github-actions bot changed the title Added Help command parameter for displaying only a specific command Added Help command parameter for displaying only a specific command (IDFGH-10725) Jul 24, 2023
components/console/commands.c Show resolved Hide resolved
components/console/commands.c Show resolved Hide resolved
Copy link
Contributor

@0xjakob 0xjakob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnorgan Code looks good, thanks for the contribution! Please squash and (ideally) rebase the commits so we can apply the commit directly. If we need to change your history, your authorship will be retained but this PR will later only be marked as "closed" instead of "merged".

@0xjakob
Copy link
Contributor

0xjakob commented Aug 11, 2023

sha=dec47be2532355fdeda4a9afcf12e1b5ae10c576

@0xjakob 0xjakob added the PR-Sync-Merge Pull request sync as merge commit label Aug 11, 2023
@0xjakob
Copy link
Contributor

0xjakob commented Aug 11, 2023

sha=0ef3c8f3600ad1e4888feb22d619882f512ab9fd

@0xjakob 0xjakob added PR-Sync-Merge Pull request sync as merge commit and removed PR-Sync-Merge Pull request sync as merge commit labels Aug 11, 2023
@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Selected for Development Issue is selected for development Status: Reviewing Issue is being reviewed labels Aug 16, 2023
@Alvin1Zhang
Copy link
Collaborator

Thanks for contribution again, changes have been merged with 0b595f3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants