Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pointer cast + condition (IDFGH-10697) #11923

Closed
wants to merge 2 commits into from
Closed

fix pointer cast + condition (IDFGH-10697) #11923

wants to merge 2 commits into from

Conversation

alexxmos
Copy link
Contributor

@alexxmos alexxmos commented Jul 20, 2023 •
edited
Loading

Fixed issues that prevented the correct use of ATECC608 in custom mode:

  • Updated condition to use the right data for comparison
  • Added missing brackets when casting variable

@CLAassistant
Copy link

CLAassistant commented Jul 20, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Jul 20, 2023
@github-actions github-actions bot changed the title fix pointer cast + condition fix pointer cast + condition (IDFGH-10697) Jul 20, 2023
AdityaHPatwardhan
AdityaHPatwardhan reviewed Jul 21, 2023
View reviewed changes
Copy link
Collaborator

@AdityaHPatwardhan AdityaHPatwardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alexxmos
Just one nitpick, since we are anyways updating that line.
The MR looks good to me,
Thanks for finding out the issue and raising the fix.

@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Jul 26, 2023
@AdityaHPatwardhan
Copy link
Collaborator

@alexxmos Can you please update the changes in the same commit.
If I edit the commit then the commit SHA would change and it may lead to your contribution not being properly displayed.

@alexxmos @AdityaHPatwardhan
Update components/esp-tls/esp_tls_mbedtls.c
3430778 
formatting

Co-authored-by: Aditya Patwardhan <[email protected]>
@alexxmos
Copy link
Contributor Author

@AdityaHPatwardhan thanks, just applied the suggestion, let me know if that's ok.

@mahavirj
Copy link
Member

mahavirj commented Aug 1, 2023

@alexxmos Please squash the commits. Also it would be good if you could add more details in the commit message. Thanks.

@mahavirj mahavirj added the PR-Sync-Rebase Pull request sync as rebase commit label Aug 14, 2023
@mahavirj
Copy link
Member

sha=34307789300404c9268e1177d66d3291589ba011

@mahavirj mahavirj added PR-Sync-Rebase Pull request sync as rebase commit and removed PR-Sync-Rebase Pull request sync as rebase commit labels Aug 14, 2023
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: In Progress Work is in progress labels Aug 16, 2023
espressif-bot pushed a commit that referenced this pull request Aug 28, 2023
@alexxmos @mahavirj
fix(esp-tls): fix pointer cast and condition for CONFIG_ATECC608A_TCU…
97bdb74 
…STOM

Closes #11923
espressif-bot pushed a commit that referenced this pull request Sep 1, 2023
@alexxmos @mahavirj
fix(esp-tls): fix pointer cast and condition for CONFIG_ATECC608A_TCU…
1360b5f 
…STOM

Closes #11923
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaHPatwardhan AdityaHPatwardhan AdityaHPatwardhan left review comments

Assignees
No one assigned
Labels
PR-Sync-Rebase Pull request sync as rebase commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexxmos @CLAassistant @AdityaHPatwardhan @mahavirj @espressif-bot