Show Package name when displaying PackageCard #38
Conversation
Display each package's `.name` property on `PackageCard`, in small, `[]` wrapped text, just after the title. This helps users determine which packages they've already installed or used. Resolves espanso#35.
|
Thanks for the PR @DylanLacey! Showing the What do you think?
|
The Package name can be displayed in a way that's a bit more stylish, and should be displayed in multiple places. Moved the package name from `PackageCard.tsx` to its own component, `PackageNamer.tsx`. Applied `code` styling and `green600` because it's a nice accent.
|
Great suggestion @arabello! I've made those changes. 
I also think it's worth making the package name more obvious on the package details screen. Yes, it's present in the install command, but I think it also belongs with the other package metadata. I added it between the package title and author because the lower amount of horizontal space made placing it inline with the title look... weird. I've included those changes; See below. 
|
There was a problem hiding this comment.
It looks nice!
Just one thing: the package.name was already shown as header title. If we want the package.name to be shown underneath the title using PackageNamer, we should change the header title to render the package.title. Otherwise we get a data duplication
Since the name is now displayed in a `code` tag under the title, as with the `PackageCard`, we should show the Package's above, instead. (Also removed unused `Small` import)
|
GAH. Great point; I got mixed up because all the packages I was testing with had the same title as they did name >.>. I've pushed those changes. |
|
Hello! Is this PR good to be merged? Thanks! |
|
Hey guys, sorry I'm used to the "who creates, merge" policy. I'm merging. @AucaCoyan I'm giving you writing permission |
|
Thank you Matteo! and congratz to @DylanLacey for the merge! 🎉 |
Display each package's
.nameproperty onPackageCard, in small,[]wrapped text, just after the title. This helps users determine which packages they've already installed or used.Resolves #35.