New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pointer type passed to CStr::from_ptr #488

Merged

bjoernQ merged 1 commit into esp-rs:main from hulthe:cstr_cchar

Jan 6, 2025

Contributor

hulthe commented Jan 4, 2025

CStr::from_ptr takes a c_char, which is a type alias for either i8 or u8 depending on target.

fixes #487


          Fix pointer type passed to CStr::from_ptr

e89fc97

ivmarkov mentioned this pull request

Update esp-hal, esp-wifi, esp-idf and edge-net dependencies esp-rs/esp-mbedtls#63

Merged

bjoernQ approved these changes

View reviewed changes

Contributor

bjoernQ left a comment

They changed the definition at some point - better to use ffi::c_char

bjoernQ merged commit 1b2d264 into esp-rs:main

hulthe deleted the cstr_cchar branch

January 6, 2025 16:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet