-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support coex for ESP32C6 #327
Conversation
esp-wifi/src/lib.rs
Outdated
@@ -109,7 +109,7 @@ const DEFAULT_TICK_RATE_HZ: u32 = 100; | |||
struct Config { | |||
#[default(5)] | |||
rx_queue_size: usize, | |||
#[default(3)] | |||
#[default(10)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we should change the default just to get rid of some warnings
We probably will revise the defaults at some point (e.g. check #233 (review) ) and when we do it, we also need to update the documentation about it
Especially since this is user-configurable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can keep default value as #233. We can change when using because it user-configurable
Works great! Thanks a lot for this I'm not sure about changing the defaults and this needs a I tested on all supported targets and nothing broke 👍 |
Be sure to remove esp32c6 from this list when you rebase :https://github.com/esp-rs/esp-wifi/blob/7632e74285a70e155a10e8dee4b6dde50d78394f/esp-wifi/build.rs#L22 |
I'd really love to get this merged. Unfortunately reviewing this is a bit difficult since there is a merge commit in It also seems that in |
it also seems it stopped working for me 😢 |
Ah - it works when using the Got it to work by reverting @TuEmb do you want to do these changes or should I take over if you don't have the time to do this (certainly keeping your original commit) |
Thanks for reviewing @bjoernQ , Let me do these changes soon 🤝 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks for your contribution!
You just need to fix the formatting issue then we can get this in |
I updated formatting issue |
Hi @bugadani, @bjoernQ,
I created a PR to support Coex for ESP32C6. Those changes were discussed from #300
COEX
feature and created newCOEX
example for ESP32C6.big-heap
when run COEX mode.G_COEX_FUNCS
in COEX modetx_queue_size
to be greater than rx_queue_size