Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move syslog out of common, implement %ll{u,d} #317

Merged
merged 3 commits into from
Oct 31, 2023
Merged

Conversation

bugadani
Copy link
Contributor

@bugadani bugadani commented Oct 29, 2023

The goal of this PR if to make common.rs a bit shorter. It's annoying to scroll past so much unrelated code :) I've also fixed printing u64 on %llu and i64 on %lld, there are a few instances of those in the format patterns.

@bugadani bugadani changed the title Move syslog out of common Move syslog out of common, implement %ll{u,d} Oct 29, 2023
Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bjoernQ bjoernQ merged commit 34b8181 into esp-rs:main Oct 31, 2023
7 checks passed
@bugadani bugadani deleted the printf branch October 31, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants