-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't enable default features for esp*-hal #303
Conversation
3577237
to
d9e9358
Compare
This comment was marked as outdated.
This comment was marked as outdated.
997211c
to
d8842b4
Compare
ed1b738
to
52b2095
Compare
Oookay, an unexpected side-effect of the test unification is that I'm not sure if we can do this. While esp-wifi ideally shouldn't enable default HAL features, we don't want to set every default feature for every example and CI test either. Unsure how to progress. |
Unfortunately, I cannot think of another solution 🤔 |
How about a hidden feature that enables the esp32XX-hal
|
Actually, it doesn't even need to be a feature. We can just enable default feature of the hal -esp32c6 = "run --features esp32c6 --target riscv32imac-unknown-none-elf --features esp32c6-hal/embassy-time-timg0"
+esp32c6 = "run --features esp32c6 --target riscv32imac-unknown-none-elf --features esp32c6-hal/embassy-time-timg0 esp32c6-hal/default" |
967b61a
to
f33df47
Compare
IMO this PR isn't blocked on esp-hal any more, whatever solution will be picked there will not affect esp-wifi. Thanks to mabez for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.