Avoid AtomicU64 if possible, fix race condition #278
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AtomicU64 is implemented with a critical section on the ESP32{|-S3}. Multi-core aware critical sections are rather expensive, so let's see if this PR can reduce that cost.
On the S2 this is less of an issue. It is a single-core SoC, so a critical section is much smaller in number of instructions. Still I hope there is value in:
Secondly, the algorithm used to calculate the time was previously incorrect. If the cycle counter just overflowed, it was previously possible to add together the old global overflow counter with the now-overflowed cycle counter, resulting in a smaller timestamp than expected.