Implement floor() using libm #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MabezDev
approved these changes
Sep 23, 2023
There was a problem hiding this comment.
Hmm, odd that RISCV targets don't get the intrinsics emitted from compiler builtins. For some reason they were left out: https://github.com/rust-lang/compiler-builtins/blob/88e2147a0b618990e69e1dfa4a2c41ef46843a02/src/math.rs#L126-L139? Thats probably a bug.
I see no real harm in this PR though, so LGTM
|
Interesting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit this exception when trying to connect to wifi on an esp32-c6.
libmimplements the floor function, so let's add that dependency and use it here.