Fixed triggering a debug-assertion during scan

[bjoernQ]

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

• I have updated existing examples or added new ones (if applicable).
• I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
• My changes were added to the CHANGELOG.md in the proper section.
• I have added necessary changes to user code to the Migration Guide.
• My changes are in accordance to the esp-rs API guidelines

Extra:

• I have read the CONTRIBUTING.md guide and followed its instructions.

Pull Request Details 📖

Description

Fixes #2611

skip-changelog because of the change in esp-hal

Testing

Change that assert from debug_assert_eq to assert_eq and just run the wifi-dhcp example

[bjoernQ]

Failing tests seem to be random and unrelated - will just rerun them once GitHub calms down

[MabezDev]

I think we should also remove the debug assert and place a warning there instead

[bugadani]

I think we should also remove the debug assert and place a warning there instead

I disagree, making a mistake will possibly become unsound if we don't panic. That assert is verifying an unsafe precondition.

What we may do is keep the debug_assert, but warn in release, but if we do everything correctly that warning will never print and just takes up code space.

[bjoernQ]

I think we should also remove the debug assert and place a warning there instead

I disagree, making a mistake will possibly become unsound if we don't panic. That assert is verifying an unsafe precondition.

Probably a usual assert then - debug_assert didn't help much since we almost never enable debug-assertions (which is why we never noticed it)

[bugadani]

The standard library also uses debug asserts for this purpose, and misuse is UB in release - same as we would do. We can also enable debug assertions for release builds.

[MabezDev]

Alright, lets keep the debug_assert then, but can we also change this to true in hil-test and examples please

[bjoernQ]

The standard library also uses debug asserts for this purpose, and misuse is UB in release - same as we would do. We can also enable debug assertions for release builds.

We should at least test with debug-assertions enabled - then it's fine but an assert which we'll never see is ... not of much use

[bugadani]

We can recommend using debug-assertions = true if we absolutely require --release, but users will ignore both of those anyway. We could do the un-rusty thing of gating asserts with an esp-config, that way we could actually force them on by default.